Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated used ports at the NodeInfo level. #42524

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Mar 4, 2017

fixes #42523

Aggregated used ports at the NodeInfo level for `PodFitsHostPorts` predicate.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 4, 2017
@k82cn
Copy link
Member Author

k82cn commented Mar 5, 2017

@k8s-bot gce etcd3 e2e test this

@wojtek-t
Copy link
Member

wojtek-t commented Mar 7, 2017

This won't hit 1.6 anyway. I will look into it as soon as I have some time.

@wojtek-t wojtek-t added this to the v1.7 milestone Mar 7, 2017
@k82cn
Copy link
Member Author

k82cn commented Mar 8, 2017

sure, thanks :). 1.6 first!

@wojtek-t
Copy link
Member

wojtek-t commented Apr 7, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Apr 7, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41775, 39678, 42629, 42524, 43028)

@k8s-github-robot k8s-github-robot merged commit fed535e into kubernetes:master Apr 8, 2017
@k82cn k82cn deleted the used_ports_per_node branch April 8, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregated used ports at the NodeInfo level.
5 participants